]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
screenShield: Rename _liftShield to _activateDialog
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 30 Jan 2020 14:30:55 +0000 (11:30 -0300)
committerFlorian Müllner <florian.muellner@gmail.com>
Mon, 10 Feb 2020 22:30:52 +0000 (22:30 +0000)
Lifting the shield is now what happens *after* successfully logging
in, not before. Now, what we do is activate the dialog before logging
in.

Rename the method to reflect that.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/872

js/ui/screenShield.js

index b2b7c8a9537ed86602064cc82b8fa6e0c91ff853..faa1b666e4445cd07ff40e0e230c1b207ea2374a 100644 (file)
@@ -86,14 +86,14 @@ var ScreenShield = class {
         this._smartcardManager.connect('smartcard-inserted',
                                        (manager, token) => {
                                            if (this._isLocked && token.UsedToLogin)
-                                               this._liftShield();
+                                               this._activateDialog();
                                        });
 
         this._oVirtCredentialsManager = OVirt.getOVirtCredentialsManager();
         this._oVirtCredentialsManager.connect('user-authenticated',
                                               () => {
                                                   if (this._isLocked)
-                                                      this._liftShield();
+                                                      this._activateDialog();
                                               });
 
         this._loginManager = LoginManager.getLoginManager();
@@ -157,7 +157,7 @@ var ScreenShield = class {
         this._syncInhibitor();
     }
 
-    _liftShield() {
+    _activateDialog() {
         if (this._isLocked) {
             this._ensureUnlockDialog(true /* allowCancel */);
             this._dialog.activate();
@@ -220,7 +220,7 @@ var ScreenShield = class {
             GLib.unichar_isgraph(unichar))
             this._dialog.addCharacter(unichar);
 
-        this._liftShield();
+        this._activateDialog();
         return Clutter.EVENT_STOP;
     }